Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix a nil pointer dereference in firestore index creation #4041

Merged
merged 1 commit into from
Jul 15, 2020
+7 −4
Merged

Fix a nil pointer dereference in firestore index creation #4041

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions lib/backend/firestore/firestorebk.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -712,11 +712,14 @@ func EnsureIndexes(ctx context.Context, adminSvc *apiv1.FirestoreAdminClient, tu
return ConvertGRPCError(err)
}

meta := adminpb.IndexOperationMetadata{}
if err := proto.Unmarshal(operation.Metadata.Value, &meta); err != nil {
return trace.Wrap(err)
// operation can be nil if error code is codes.AlreadyExists.
if operation != nil {
meta := adminpb.IndexOperationMetadata{}
if err := proto.Unmarshal(operation.Metadata.Value, &meta); err != nil {
return trace.Wrap(err)
}
tuplesToIndexNames[tuple] = meta.Index
}
tuplesToIndexNames[tuple] = meta.Index
}

// Instead of polling the Index state, we should wait for the Operation to
Expand Down