Add missing audit log fields for k8s sessions #4057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awly
requested review from
fspmarshall,
klizhentas,
russjones and
webvictim
as code owners
|
@awly I just realized that it misses below fields as well. session_start: string;
session_stop: string;
participants?: string[]; |
Added `interactive` as needed. Added `server_hostname` and `server_addr` referring to the k8s endpoint. Added `session_start` and `session_end` for timestamps. Added `participants` to mimic SSH sessions. Fixes #4055
awly
force-pushed
the
andrew/k8s-session-events
branch
from
0024d6c to
f924493
Compare
|
@alex-kovoy thanks for catching this, added. |
russjones
approved these changes
Jul 16, 2020
|
retest this please |
3 similar comments
|
retest this please |
|
retest this please |
|
retest this please |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
interactiveas needed.Added
server_hostnameandserver_addrreferring to the k8s endpoint.Fixes #4055