DynamoDB respect HTTP Connect proxies #4271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…meters, this allows the transport to be pre-populated with proxy information if set by HTTPS_PROXY/NO_PROXY environment variables. Fixes: #4261
kgtw
requested review from
awly,
fspmarshall,
klizhentas,
russjones and
webvictim
as code owners
|
Can one of the admins verify this patch? |
|
ok to test |
|
retest this please |
awly
reviewed
Sep 1, 2020
awly
reviewed
Sep 1, 2020
awly
approved these changes
Sep 1, 2020
webvictim
approved these changes
Sep 2, 2020
|
Hi @awly, any chance of getting this merged and included in the next release? We would really like to move some of our secure environments over to using Teleport. |
|
@russjones What do you think? |
|
@russjones This came up today, this would be good issue to backport into 4.3.6 https://github.com/gravitational/teleport/milestone/43 |
russjones
approved these changes
Sep 15, 2020
awly
pushed a commit
that referenced
this pull request
Sep 29, 2020
* DynamoDB: Build http transport from defaults before manipulating parameters, this allows the transport to be pre-populated with proxy information if set by HTTPS_PROXY/NO_PROXY environment variables.
|
Fixes #4261 |
awly
pushed a commit
that referenced
this pull request
Sep 29, 2020
* DynamoDB: Build http transport from defaults before manipulating parameters, this allows the transport to be pre-populated with proxy information if set by HTTPS_PROXY/NO_PROXY environment variables.
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes (#4261) allowing DynamoDB to make calls via a HTTP proxy.