Fix server info reconciler not restarting after an error #47160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmb3
reviewed
Oct 4, 2024
| const timeBetweenReconciliationLoops = 10 * time.Minute | ||
| clock := a.GetClock() | ||
| func ReconcileServerInfos(ctx context.Context, ap ServerInfoAccessPoint) error { | ||
| retry, err := retryutils.NewLinear(retryutils.LinearConfig{ |
There was a problem hiding this comment.
Does retry need any sort of defer to stop it when this function returns?
There was a problem hiding this comment.
It doesn't have a Close() method and it doesn't have any internal things to cancel, so I don't think so.
|
Friendly ping @rosstimothy |
rosstimothy
approved these changes
Oct 9, 2024
fspmarshall
approved these changes
Oct 9, 2024
public-teleport-github-review-bot
bot
removed the request for review
from tcsc
This change fixes the server info reconciler to restart on an error.
atburke
force-pushed
the
atburke/server-info-retry
branch
from
dae720d
to
f06454b
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This was referenced Oct 10, 2024
mvbrock
pushed a commit
that referenced
this pull request
Oct 16, 2024
This change fixes the server info reconciler to restart on an error.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the server info reconciler to restart on an error.
Fixes #44793.
Changelog: Fixed the resource-based labels handler crashing without restarting