Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[v16] Expose client tools auto update for find endpoint #47213

Open
wants to merge 2 commits into
base: branch/v16
Choose a base branch
from

Conversation

vapopov
Copy link
Contributor

@vapopov vapopov commented Oct 4, 2024

Backport #46785 and #47532 to branch/v16

* Expose client tools auto update for find endpoint

* Group auto update settings in find response
Log error instead returning error
Add tests auto update settings in find endpoint
Add check for not implemented error

* Add more test cases
@vapopov vapopov added backport no-changelog Indicates that a PR does not require a changelog entry labels Oct 4, 2024
@rosstimothy
Copy link
Contributor

@sclevine are there going to be any changes required/desired to this endpoint/message to accommodate any of the new upgrades design that we should do prior to merging backports?

* Update client autoupdate proto structure

* Replace with reserved

* Fix unit tests

* Add more info in proto

* Rename proto to be aligned RFD namings

* Replace enum type for ToolsMode to string
@vapopov
Copy link
Contributor Author

vapopov commented Oct 17, 2024

@rosstimothy I've cherry picked recent changes in proto structure here as well

@vapopov vapopov closed this Nov 8, 2024
@vapopov vapopov reopened this Nov 8, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-47213.d212ksyjt6y4yg.amplifyapp.com

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
backport no-changelog Indicates that a PR does not require a changelog entry size/md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants