feat: SSO MFA - Incorporate SSO into cli mfa method preferences #47839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Joerger
added
the
no-changelog
Joerger
force-pushed
the
joerger/mfa-method-preferences
branch
3 times, most recently
from
c824e93
to
2420095
Compare
codingllama
reviewed
Oct 23, 2024
Joerger
force-pushed
the
joerger/mfa-method-preferences
branch
from
9df809b
to
c95d128
Compare
Joerger
force-pushed
the
joerger/mfa-method-preferences
branch
from
b673e04
to
913a35c
Compare
flyinghermit
approved these changes
Oct 23, 2024
codingllama
reviewed
Oct 24, 2024
| @@ -101,40 +107,71 @@ func (c *CLIPrompt) Run(ctx context.Context, chal *proto.MFAAuthenticateChalleng | |||
|
|
|||
| promptOTP := chal.TOTP != nil | |||
| promptWebauthn := chal.WebauthnChallenge != nil | |||
| promptSSO := false // TODO(Joerger): check for SSO challenge once added in separate PR. | |||
There was a problem hiding this comment.
I do appreciate the small change but it looks like we are mainly adding dead code to this file. Would it make sense to do a bit more here, so at least we can test the "SSO not implemented" error? Or maybe move some changes to a PR where they are effective?
There was a problem hiding this comment.
Sure, in that case I'll merge this into #46982
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the implementation of #44699
Implements the UX proposed in the RFD for CLI prompts.
Depends on #47874