add info to auto upgrade version fetch error #48558
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GavinFrazar
added
no-changelog
marcoandredinis
approved these changes
Nov 7, 2024
gzdunek
approved these changes
Nov 7, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tiny PR adds a little bit of info when failing to fetch the version from auto upgrades
forward_url.Without this, the error can be really unhelpful in the web UI, i.e it would just say "non-200 status code received: '404'" without explaining what it was trying to do.
I ran into this error because of #48508 while going through the RDS enrollment wizard in the web ui - basically it's because the
stable/cloud/v17upgrade channel doesn't exist yet, so GET returns 404.Now at least it's a little more specific about what it was trying to fetch: