Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix the icon story generation template #48573

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

ryanclark
Copy link
Contributor

I'm not entirely sure why but it looks like this template hasn't generated the code that we have in Icons.story.tsx for a while - the types are missing and the imports don't match. This updates the template to match the code.

Copy link
Contributor

@avatus avatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I defer to @rudream on this one

@ryanclark ryanclark added this pull request to the merge queue Nov 8, 2024
Merged via the queue into master with commit 6ce98e2 Nov 8, 2024
42 checks passed
@ryanclark ryanclark deleted the ryan/fix-icon-story-template branch November 8, 2024 07:45
@public-teleport-github-review-bot

@ryanclark See the table below for backport results.

Branch Result
branch/v16 Create PR
branch/v17 Create PR

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
backport/branch/v16 backport/branch/v17 no-changelog Indicates that a PR does not require a changelog entry size/sm ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants