Backport: fix response flushing on streaming k8s requests #5010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Streaming requests, like `kubectl logs -f` will slowly write response data over time. The `http.ResponseWriter` wrapper we added for capturing the response code didn't propagate `http.Flusher` interface and prevented the forwarder library from periodically flushing response contents. This caused `kubectl logs -f` results to be delayed, delivered in batches as some internal buffer filled up.
awly
requested review from
a-palchikov,
fspmarshall,
klizhentas,
r0mant,
russjones and
webvictim
as code owners
a-palchikov
approved these changes
Dec 1, 2020
r0mant
approved these changes
Dec 1, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #5009 into 5.0
Streaming requests, like
kubectl logs -fwill slowly write responsedata over time. The
http.ResponseWriterwrapper we added for capturingthe response code didn't propagate
http.Flusherinterface andprevented the forwarder library from periodically flushing response
contents.
This caused
kubectl logs -fresults to be delayed, delivered inbatches as some internal buffer filled up.