Fixes ACME default configuration #5839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@russjones @r0mant can you folks please review |
Fixes #5771, tctl configure has to generate port :443 when ACME is on, because TLS-ALPN-01 challenge only works on 443 port.
klizhentas
force-pushed
the
sasha/acmectl
branch
from
d2e6ae9 to
faece9f
Compare
|
I just tried this on a new cluster and it worked using the below, the one unrelated issue would be to change how we setup configure. I have a note below. teleport:
nodename: ip-172-31-13-209
data_dir: /var/lib/teleport
log:
output: stderr
severity: INFO
ca_pin: ""
auth_service:
enabled: "yes"
listen_addr: 0.0.0.0:3025
cluster_name: silver.asteroid.earth
ssh_service:
enabled: "yes"
labels:
env: example
commands:
- name: hostname
command: [hostname]
period: 1m0s
proxy_service:
enabled: "yes"
listen_addr: 0.0.0.0:3023
web_listen_addr: :443
public_addr: silver.asteroid.earth:443
https_keypairs: []
acme:
enabled: "yes"
email: ben@goteleport.comWhen using the new script, I've noticed that the TLS certificate adds the node name into the cert. I've found that setting a public_addr is better as an IP/FQDN is needed for plugins to work. |
russjones
approved these changes
Mar 5, 2021
Comment on lines
+385
to
+386
| p.PublicAddr = utils.Strings{net.JoinHostPort(flags.ClusterName, fmt.Sprintf("%d", teleport.StandardHTTPSPort))} | ||
| p.WebAddr = fmt.Sprintf(":%d", teleport.StandardHTTPSPort) |
There was a problem hiding this comment.
You can use strconv.Itoa here like the following:
p.PublicAddr = utils.Strings{net.JoinHostPort(flags.ClusterName, strconv.Itoa(teleport.StandardHTTPSPort))}
p.WebAddr = net.JoinHostPort("", strconv.Itoa(teleport.StandardHTTPSPort))
|
@benarent not sure I follow, can you please elaborate on the IP/FQDN? |
^ I'm going to create another ticket that outlines this issue. |
klizhentas
added a commit
that referenced
this pull request
Mar 5, 2021
Fixes #5771, tctl configure has to generate port :443 when ACME is on, because TLS-ALPN-01 challenge only works on 443 port.
russjones
pushed a commit
that referenced
this pull request
Mar 6, 2021
Fixes #5771, tctl configure has to generate port :443 when ACME is on, because TLS-ALPN-01 challenge only works on 443 port.
klizhentas
added a commit
that referenced
this pull request
Mar 6, 2021
Fixes #5771, tctl configure has to generate port :443 when ACME is on, because TLS-ALPN-01 challenge only works on 443 port.
klizhentas
added a commit
that referenced
this pull request
Mar 6, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5771, tctl configure has to generate port :443
when ACME is on, because TLS-ALPN-01 challenge only works on 443 port.