Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

ADFS fix #5880

Merged
merged 2 commits into from
Mar 6, 2021
Merged

ADFS fix #5880

merged 2 commits into from
Mar 6, 2021

Conversation

Joerger
Copy link
Contributor

@Joerger Joerger commented Mar 5, 2021

No description provided.

russjones
russjones reviewed Mar 5, 2021
View reviewed changes
lib/services/saml.go Outdated Show resolved Hide resolved
russjones
russjones reviewed Mar 5, 2021
View reviewed changes
Copy link
Contributor

@russjones russjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Joerger Did you test this with @stevenGravy ?

@Joerger Joerger requested a review from russjones March 5, 2021 20:18
@Joerger
Copy link
Contributor Author

Joerger commented Mar 5, 2021

@Joerger Did you test this with @stevenGravy ?

He said he'd let me know when he tests it. It was a very simple typo, so I'm confident that this will work now.

russjones
russjones approved these changes Mar 5, 2021
View reviewed changes
Copy link
Contributor

@russjones russjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Joerger Approved pending @stevenGravy confirming.

r0mant
r0mant approved these changes Mar 5, 2021
View reviewed changes
lib/services/saml.go Outdated Show resolved Hide resolved
@Joerger Joerger force-pushed the joerger/ADFS-fix branch from 27172f8 to 2263e9c Compare March 5, 2021 22:50
@Joerger Joerger force-pushed the joerger/ADFS-fix branch from 2263e9c to 2d0392b Compare March 5, 2021 22:51
@russjones russjones merged commit 66913aa into master Mar 6, 2021
@russjones russjones deleted the joerger/ADFS-fix branch March 6, 2021 00:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@r0mant r0mant r0mant approved these changes

@russjones russjones russjones approved these changes

@klizhentas klizhentas Awaiting requested review from klizhentas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Joerger @r0mant @russjones