Backport: mfa: prevent the user from deleting the last MFA device #6625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* mfa: prevent the user from deleting the last MFA device When the cluster requires MFA for all users (when `second_factor` is `on`, `u2f` or `totp`, and not `off` or `optional`), users could lock themselves out by deleting the last device. Prevent that. Fixes #5803 * Make last MFA device deletion check more strict Separate by the type of the device and which type the cluster enforces.
r0mant
approved these changes
Apr 28, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #6585 into v6
When the cluster requires MFA for all users (when
second_factorison,u2fortotp, and notofforoptional), users could lockthemselves out by deleting the last device. Prevent that.
Fixes #5803
Separate by the type of the device and which type the cluster enforces.