This repository has been archived by the owner on Feb 8, 2024. It is now read-only.
Update Empty state to new layout #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pplications view.
zmb3
reviewed
Mar 21, 2022
kimlisa
reviewed
Mar 22, 2022
|
there is also odd jumping of the empty states and it seems to happens when the image renders later? the text renders first which makes the height of the container small, then image decides to join in, which causes the jumping of the height of the container. Can we maybe set a height to the image container so that we have a "placeholder" so the rendering process is smoother? |
rudream
reviewed
Mar 24, 2022
kimlisa
reviewed
Mar 24, 2022
kimlisa
reviewed
Mar 25, 2022
kimlisa
approved these changes
Mar 25, 2022
rudream
reviewed
Mar 25, 2022
rudream
reviewed
Mar 25, 2022
rudream
approved these changes
Mar 25, 2022
hatched
added a commit
that referenced
this pull request
Mar 25, 2022
Update Empty state to new layout
hatched
added a commit
that referenced
this pull request
Mar 25, 2022
[v9] Update Empty state to new layout #686
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the layout when there are no entities of a certain type to the new designs.
Fixes: gravitational/teleport#10339
Note
There is a jarring flash of the loading indicator when switching between views because the state always enters the
processingstate. We should look into resolving this with an update to the loading indicator de# a follow-up.