Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add checks to user update processing #2158

Merged
merged 2 commits into from
Apr 4, 2023
Merged

Conversation

mattkasun
Copy link
Contributor

Describe your changes

also addresses GRA-1480

Provide Issue ticket number if applicable/not in title

Provide testing steps

Checklist before requesting a review

  • My changes affect only 10 files or less.
  • I have performed a self-review of my code and tested it.
  • If it is a new feature, I have added thorough tests, my code is <= 1450 lines.
  • If it is a bugfix, my code is <= 200 lines.
  • My functions are <= 80 lines.
  • I have had my code reviewed by a peer.
  • My unit tests pass locally.
  • Netmaker is awesome.

@mattkasun mattkasun requested a review from 0xdcarns April 3, 2023 13:54
@theguy951357
Copy link
Contributor

will wait on changes

@mattkasun mattkasun requested a review from abhishek9686 April 4, 2023 12:46
Copy link
Contributor

@theguy951357 theguy951357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-admin user cannot change the credentials of an admin user.
critical list passes

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants