Skip to content

fix: use local path source_folder if not empty #68

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Oct 11, 2022

Conversation

Vinai
Copy link
Contributor

@Vinai Vinai commented Oct 11, 2022

This allows using the action in https://github.com/mage-os/generate-mirror-repo-js where the test module is an external package installed with composer. In this case, no local path repo configuration is needed.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Currently the action fails if the local repo path url points to a non-existing folder or to a folder without a composer.json file.

What is the new behavior?

The action completes since no local path repo is configured

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

This allows using the action in https://github.com/mage-os/generate-mirror-repo-js where the test module is an external package installed with composer. In this case, no local path repo configuration is needed.
@Vinai Vinai requested a review from damienwebdev as a code owner October 11, 2022 10:14
Vinai added a commit to mage-os/generate-mirror-repo-js that referenced this pull request Oct 11, 2022
@damienwebdev
Copy link
Member

damienwebdev commented Oct 11, 2022

@Vinai I think you also meant to change this file.

- run: composer config repositories.local path ${{ inputs.source_folder }}

@Vinai
Copy link
Contributor Author

Vinai commented Oct 11, 2022

@damienwebdev Indeed you are right. That change got lost, not used to editing in the browser ;)

@damienwebdev damienwebdev changed the base branch from allow_using_next_version to main October 11, 2022 14:52
@damienwebdev damienwebdev changed the base branch from main to allow_using_next_version October 11, 2022 14:52
@damienwebdev damienwebdev merged commit 05b492e into graycoreio:allow_using_next_version Oct 11, 2022
Vinai added a commit to mage-os/generate-mirror-repo-js that referenced this pull request Oct 11, 2022
damienwebdev pushed a commit that referenced this pull request Oct 11, 2022
…ded (#68)

This allows using the action in https://github.com/mage-os/generate-mirror-repo-js where the test module is an external package installed with composer. In this case, no local path repo configuration is needed.
Vinai added a commit to mage-os/generate-mirror-repo-js that referenced this pull request Oct 12, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants