Add support for building Linux AppImage binary. #133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoinevg
changed the title
antoinevg
force-pushed
the
antoinevg/linux-appimage
branch
5 times, most recently
from
68eb195 to
8abe941
Compare
antoinevg
force-pushed
the
antoinevg/linux-appimage
branch
2 times, most recently
from
8abe941 to
2e5a432
Compare
antoinevg
force-pushed
the
antoinevg/linux-appimage
branch
from
2e5a432 to
c0dab44
Compare
antoinevg
force-pushed
the
antoinevg/linux-appimage
branch
3 times, most recently
from
a6fd72b to
58e33e2
Compare
antoinevg
force-pushed
the
antoinevg/linux-appimage
branch
from
9475402 to
1c1c236
Compare
|
Closed in favour of #140 so it can actually be tested. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for building the Linux AppImage binary during CI workflow.
Overview
The workflow file is .github/workflows/appimage.yml and is structured as follows:
Step 1: Checks if the docker container exists or needs to be updated, if not, go to Step 3.
Step 2: Builds the appimage/docker/Dockerfile for compiling packetry and creating an appimage.
Step 3: Runs pretty much the same workflow as the
rust.ymlworkflow to compile & test packetry inside the docker container.Step 4: Invokes a custom action appimage/action.yml to build the Linux AppImage binary.
Step 5: Uploads the Linux AppImage binary artifact.
Docker Image Notes
GTK_VERSIONsets the version of GTK sources to be downloaded and built.NODE_VERSIONsets the version of node to install for the use ofSwatinem/rust-cache@v2USER rootbut it turns out that was wasted becauseGitHub Actions does not support containers running as anything but root:
$HOMEfor the root user with/github/homewhich of course causes all thethings to fail.
/github/homein your container, GitHub actions will happily delete the contents./etc/passwdto changeroothome dir to/github/homeduring the container build and then copying everything you need into$HOMEbefore running the workflow.<repo>-gtk-<gtk-version>:<branch>so we don't run into issues when working on branches or PR's.Outstanding issues
DOCKER_REGISTRY_TOKENfor the packetry repo.