Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove "applyOverrides" from report content composer #1090

Merged
merged 2 commits into from
Dec 12, 2018

Conversation

swaterkamp
Copy link
Member

Also, drop filler words in dialogs

@swaterkamp swaterkamp self-assigned this Dec 12, 2018
@codecov
Copy link

codecov bot commented Dec 12, 2018

Codecov Report

Merging #1090 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1090      +/-   ##
==========================================
+ Coverage   14.95%   14.95%   +<.01%     
==========================================
  Files         832      832              
  Lines       26844    26841       -3     
  Branches     5653     5668      +15     
==========================================
  Hits         4015     4015              
+ Misses      21427    21424       -3     
  Partials     1402     1402
Impacted Files Coverage Δ
gsa/src/web/pages/reports/alertactions.js 0% <ø> (ø) ⬆️
gsa/src/web/pages/reports/downloadreportdialog.js 0% <ø> (ø) ⬆️
gsa/src/web/pages/reports/triggeralertdialog.js 0% <ø> (ø) ⬆️
gsa/src/web/pages/reports/detailspage.js 0% <ø> (ø) ⬆️
gsa/src/web/components/dialog/composercontent.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5876e95...a49936a. Read the comment docs.

@bjoernricks bjoernricks merged commit cbc4962 into greenbone:master Dec 12, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants