Remediation module #1126
Merged
Remediation module #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoernricks
added
the
work in progress
Codecov Report
@@ Coverage Diff @@
## master #1126 +/- ##
==========================================
+ Coverage 15.38% 16.13% +0.74%
==========================================
Files 919 940 +21
Lines 27233 27697 +464
Branches 5777 5860 +83
==========================================
+ Hits 4191 4469 +278
- Misses 21648 21842 +194
+ Partials 1394 1386 -8
Continue to review full report at Codecov.
|
swaterkamp
reviewed
Jan 30, 2019
swaterkamp
reviewed
Jan 31, 2019
swaterkamp
reviewed
Jan 31, 2019
swaterkamp
reviewed
Jan 31, 2019
swaterkamp
reviewed
Jan 31, 2019
swaterkamp
reviewed
Jan 31, 2019
swaterkamp
reviewed
Jan 31, 2019
swaterkamp
reviewed
Jan 31, 2019
swaterkamp
reviewed
Jan 31, 2019
swaterkamp
reviewed
Jan 31, 2019
swaterkamp
reviewed
Jan 31, 2019
swaterkamp
reviewed
Jan 31, 2019
swaterkamp
reviewed
Jan 31, 2019
swaterkamp
reviewed
Jan 31, 2019
swaterkamp
reviewed
Jan 31, 2019
swaterkamp
reviewed
Jan 31, 2019
swaterkamp
reviewed
Jan 31, 2019
swaterkamp
reviewed
Jan 31, 2019
| }); | ||
| }); | ||
|
|
||
| test('should trim note when saveing a ticket', () => { |
There was a problem hiding this comment.
Small typo: should be "saving"
bjoernricks
removed
the
work in progress
swaterkamp
previously approved these changes
Jan 31, 2019
There was a problem hiding this comment.
After trying this out I haven't found any major problems but I think @mattmundell would have a better idea of which features to test as he implemented them in gvmd.
Parse properties for Ticket models.
Add helper functions for testing command classes.
* comment fields got renamed to note * status names got renamed * open state got an explicit note field * require always a note
Also trim the note. A user must always add a note.
A ticket can't be in the state orphaned anymore.
This has been changed for the ticket comments to support newline. By using a different paramerter (note) now this change is obsolete and should be reverted.
Use correct name for ticket status color scale.
Parse the tickets only as model instances because we currently only get ids.
If the user may access tickets and if the result is connected to one or more tickets display a ticket icon with a badge that links to the ticket list with a filter for the current result id.
Display ticket icon if a result has one or more tickets at the results list page.
Save open_note, closed_note and fixed_note when modifying a ticket.
Provide open, closed and fixed notes when saving a ticket.
Allow to edit the open, fixed and close notes of a ticket at once.
Allow for easier referencing the buttons in tests.
The name attribute wasn't evaluated but nevertheless it should be correct here.
swaterkamp
approved these changes
Feb 4, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft for the remediation module
Requires greenbone/gvmd@884a176
Still Missing:
Assigned To User Name -> Missing patch for gvmdTicket Details PageBetter icons for solve, close and create a ticket plus a ticket list iconWe use the standard edit icon for state changesTickets list in trashcanRestore tickets from trashcanOpened Ticket Comment -> Missing patch for gvmdUse new status names for communication with gvmdIndicator for existing tickets at result list and result details pagesDashboard ID for saving and loading the ticket dashboardPie chart Ticket StatusLine chart Status Open over timeImplemented as created tickets over timeBubble Chart: Assigned to userAll tickets independent of the state assigned to a user. Should we remove closed tickets? or should we display only open tickets?Table displays at the dashboard for ticketsTicket charts at main dashboardChecklist: