Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Render dates in current configured timezone #1327

Merged
merged 4 commits into from
Apr 26, 2019
Merged

Render dates in current configured timezone #1327

merged 4 commits into from
Apr 26, 2019

Conversation

bjoernricks
Copy link
Contributor

@bjoernricks bjoernricks commented Apr 26, 2019

Checklist:

Add a function to ensure a passed date is a date.
This allows to display all dates in the current timezone configured at
the user settings.
@bjoernricks bjoernricks marked this pull request as ready for review April 26, 2019 12:50
@bjoernricks bjoernricks requested a review from swaterkamp as a code owner April 26, 2019 12:50
@bjoernricks bjoernricks requested a review from a team April 26, 2019 12:50
@codecov
Copy link

codecov bot commented Apr 26, 2019

Codecov Report

Merging #1327 into gsa-8.0 will increase coverage by 0.01%.
The diff coverage is 58.82%.

Impacted file tree graph

@@             Coverage Diff             @@
##           gsa-8.0    #1327      +/-   ##
===========================================
+ Coverage    34.39%   34.41%   +0.01%     
===========================================
  Files          958      959       +1     
  Lines        21573    21578       +5     
  Branches      5950     5950              
===========================================
+ Hits          7420     7426       +6     
+ Misses       12799    12798       -1     
  Partials      1354     1354
Impacted Files Coverage Δ
gsa/src/web/pages/dfncert/row.js 40% <ø> (ø) ⬆️
gsa/src/web/pages/hosts/row.js 19.04% <ø> (+1.65%) ⬆️
gsa/src/web/pages/certbund/row.js 40% <ø> (ø) ⬆️
gsa/src/web/pages/tags/row.js 25% <ø> (ø) ⬆️
gsa/src/web/pages/tickets/table.js 63.63% <ø> (ø) ⬆️
gsa/src/web/pages/cpes/row.js 40% <ø> (ø) ⬆️
gsa/src/web/pages/tasks/row.js 11.76% <ø> (+0.33%) ⬆️
gsa/src/web/pages/operatingsystems/row.js 40% <ø> (ø) ⬆️
gsa/src/web/pages/results/row.js 8% <ø> (ø) ⬆️
gsa/src/web/pages/ovaldefs/row.js 40% <ø> (ø) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27f92bb...d0c2acb. Read the comment docs.

@swaterkamp swaterkamp merged commit e6782ee into greenbone:gsa-8.0 Apr 26, 2019
@bjoernricks bjoernricks deleted the fix-timezone-handling branch April 26, 2019 14:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants