Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Reset timer to undefined if the timer is cleared #1341

Merged
merged 3 commits into from
Apr 30, 2019
Merged

Reset timer to undefined if the timer is cleared #1341

merged 3 commits into from
Apr 30, 2019

Conversation

bjoernricks
Copy link
Contributor

@bjoernricks bjoernricks commented Apr 30, 2019

If the timer is not reset it is not possible to start a new one.

Checklist:

If the timer is not reset it is not possible to start a new one.
Allow to debug the reason for not started timers in future.
@bjoernricks bjoernricks marked this pull request as ready for review April 30, 2019 09:44
@bjoernricks bjoernricks requested a review from swaterkamp as a code owner April 30, 2019 09:44
@bjoernricks bjoernricks requested a review from a team April 30, 2019 09:44
@codecov
Copy link

codecov bot commented Apr 30, 2019

Codecov Report

Merging #1341 into gsa-8.0 will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           gsa-8.0    #1341      +/-   ##
===========================================
- Coverage    34.73%   34.73%   -0.01%     
===========================================
  Files          959      959              
  Lines        21599    21603       +4     
  Branches      5979     5979              
===========================================
  Hits          7503     7503              
- Misses       12755    12759       +4     
  Partials      1341     1341
Impacted Files Coverage Δ
gsa/src/web/entities/container.js 1.07% <0%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf5c3d7...093eb4a. Read the comment docs.

@bjoernricks bjoernricks merged commit a3641ff into greenbone:gsa-8.0 Apr 30, 2019
@bjoernricks bjoernricks deleted the fix-clearing-reload-timer branch April 30, 2019 11:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants