Disable EditIcon while loading filters (also fix loading filters) #1383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## gsa-8.0 #1383 +/- ##
===========================================
+ Coverage 36.1% 36.15% +0.04%
===========================================
Files 960 960
Lines 21679 21652 -27
Branches 6014 6014
===========================================
Hits 7828 7828
+ Misses 12515 12488 -27
Partials 1336 1336
Continue to review full report at Codecov.
|
swaterkamp
force-pushed
the
RaceCondSettings
branch
from
5e13d6d to
04d4714
Compare
swaterkamp
changed the title
bjoernricks
approved these changes
May 10, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will prevent a race condition when opening the EditDialog. Before this change, it was possible that the dialog opened before all settings (filters in particular) where loaded.
Checklist: