Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

modified y-domain to avoid range [0,0] #1447

Merged
merged 2 commits into from
Jun 20, 2019

Conversation

saberlynx
Copy link
Contributor

@saberlynx saberlynx commented Jun 20, 2019

modified y-domain to avoid range [0,0]. The previous version had y-domain [0,0] with default data.
Checklist:

@codecov
Copy link

codecov bot commented Jun 20, 2019

Codecov Report

Merging #1447 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1447      +/-   ##
==========================================
- Coverage   36.71%   36.71%   -0.01%     
==========================================
  Files         989      989              
  Lines       22185    22186       +1     
  Branches     6088     6111      +23     
==========================================
  Hits         8145     8145              
- Misses      12715    12716       +1     
  Partials     1325     1325
Impacted Files Coverage Δ
gsa/src/web/components/chart/bar.js 11.53% <0%> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6507d6...e01abaa. Read the comment docs.

@saberlynx saberlynx marked this pull request as ready for review June 20, 2019 09:10
@saberlynx saberlynx requested a review from bjoernricks June 20, 2019 09:38
@saberlynx saberlynx requested a review from swaterkamp as a code owner June 20, 2019 09:58
@saberlynx saberlynx requested a review from a team June 20, 2019 09:58
@bjoernricks bjoernricks merged commit 774f362 into greenbone:master Jun 20, 2019
@saberlynx saberlynx deleted the bardisplay branch June 21, 2019 10:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants