Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Changed the filter dialogues for tasks and overrides #1511

Merged
merged 9 commits into from
Jul 24, 2019
Merged

Changed the filter dialogues for tasks and overrides #1511

merged 9 commits into from
Jul 24, 2019

Conversation

saberlynx
Copy link
Contributor

@saberlynx saberlynx commented Jul 24, 2019 •
edited
Loading

  • Changed the filter dialogues for tasks and overrides
  • added tasktrendgroup component.

Checklist:

@saberlynx saberlynx force-pushed the tasksOverridesFilter branch from 5f3d7e3 to a3611e8 Compare July 24, 2019 10:21
@codecov
Copy link

codecov bot commented Jul 24, 2019 •
edited
Loading

Codecov Report

Merging #1511 into master will increase coverage by <.01%.
The diff coverage is 53.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1511      +/-   ##
==========================================
+ Coverage   37.12%   37.13%   +<.01%     
==========================================
  Files        1000     1001       +1     
  Lines       22317    22330      +13     
  Branches     6138     6143       +5     
==========================================
+ Hits         8286     8293       +7     
- Misses      12717    12722       +5     
- Partials     1314     1315       +1
Impacted Files Coverage Δ
gsa/src/web/pages/tasks/filterdialog.js 33.33% <ø> (ø) ⬆️
...a/src/web/components/powerfilter/tasktrendgroup.js 100% <100%> (ø)
gsa/src/web/pages/overrides/filterdialog.js 33.33% <25%> (-66.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8b6e5c...a05d02d. Read the comment docs.

@saberlynx saberlynx marked this pull request as ready for review July 24, 2019 11:21
bjoernricks
bjoernricks requested changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just small changes.

gsa/src/web/components/powerfilter/__tests__/tasktrendgroup.js Outdated Show resolved Hide resolved
gsa/src/web/components/powerfilter/tasktrendgroup.js Outdated Show resolved Hide resolved
gsa/src/web/components/powerfilter/tasktrendgroup.js Outdated Show resolved Hide resolved
saberlynx and others added 2 commits July 24, 2019 13:35
@saberlynx @bjoernricks
Apply suggestions from code review
8ab21f5 
changed import path to absolute

Co-Authored-By: Björn Ricks <bjoern.ricks@gmail.com>
@saberlynx
modified tasktrendgroup test to import method instead
a05d02d
@bjoernricks bjoernricks merged commit 5d0bee1 into greenbone:master Jul 24, 2019
@saberlynx saberlynx deleted the tasksOverridesFilter branch July 24, 2019 13:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@bjoernricks bjoernricks bjoernricks approved these changes

@swaterkamp swaterkamp Awaiting requested review from swaterkamp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saberlynx @bjoernricks