Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Show correct information at task details #1515

Merged
merged 2 commits into from
Jul 24, 2019

Conversation

swaterkamp
Copy link
Member

This concerns max_checks and max_hosts, which were parsed to another
field in the task model

Checklist:

This concerns max_checks and max_hosts, which were parsed to the wrong 
field in the task model
@swaterkamp swaterkamp requested a review from bjoernricks July 24, 2019 14:23
@swaterkamp swaterkamp self-assigned this Jul 24, 2019
@swaterkamp swaterkamp marked this pull request as ready for review July 24, 2019 14:24
@swaterkamp swaterkamp requested a review from a team July 24, 2019 14:24
@codecov
Copy link

codecov bot commented Jul 24, 2019

Codecov Report

Merging #1515 into gsa-8.0 will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           gsa-8.0   #1515   +/-   ##
=======================================
  Coverage     37.5%   37.5%           
=======================================
  Files          965     965           
  Lines        21932   21932           
  Branches      6097    6097           
=======================================
  Hits          8225    8225           
  Misses       12406   12406           
  Partials      1301    1301
Impacted Files Coverage Δ
gsa/src/web/pages/tasks/details.js 5.06% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44c0452...55d233a. Read the comment docs.

Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit

@bjoernricks bjoernricks merged commit a3a7553 into greenbone:gsa-8.0 Jul 24, 2019
@swaterkamp swaterkamp deleted the TaskDetails branch July 24, 2019 15:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants