Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixed userId, roleId and groupId not rendering in create entity permissions dialog #1658

Merged
merged 5 commits into from
Oct 2, 2019

Conversation

saberlynx
Copy link
Contributor

@saberlynx saberlynx commented Oct 1, 2019

Checklist:

@codecov
Copy link

codecov bot commented Oct 1, 2019

Codecov Report

Merging #1658 into gsa-8.0 will decrease coverage by <.01%.
The diff coverage is 25%.

Impacted file tree graph

@@             Coverage Diff             @@
##           gsa-8.0    #1658      +/-   ##
===========================================
- Coverage    37.65%   37.65%   -0.01%     
===========================================
  Files          966      966              
  Lines        22110    22114       +4     
  Branches      6210     6210              
===========================================
+ Hits          8325     8326       +1     
- Misses       12460    12463       +3     
  Partials      1325     1325
Impacted Files Coverage Δ
gsa/src/web/entity/permissions.js 9.72% <0%> (-0.43%) ⬇️
gsa/src/web/pages/permissions/multipledialog.js 15.78% <100%> (+2.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a146554...bb1c724. Read the comment docs.

@saberlynx saberlynx marked this pull request as ready for review October 2, 2019 04:54
@saberlynx saberlynx requested a review from a team October 2, 2019 04:54
@bjoernricks bjoernricks merged commit 8a339bf into greenbone:gsa-8.0 Oct 2, 2019
@saberlynx saberlynx deleted the permissions-create branch October 2, 2019 09:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants