Severity levels #1869
Merged
Severity levels #1869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update SeverityLevelsFilterGroup to remove the levels filter term if levels is empty.
Add remove handler to all existing tests to fix proptype warnings and add test for calling the remove handler if all levels are unchecked.
Codecov Report
@@ Coverage Diff @@
## gsa-8.0 #1869 +/- ##
===========================================
+ Coverage 39.82% 39.83% +<.01%
===========================================
Files 979 979
Lines 22636 22641 +5
Branches 6368 6395 +27
===========================================
+ Hits 9015 9019 +4
- Misses 12311 12313 +2
+ Partials 1310 1309 -1
Continue to review full report at Codecov.
|
swaterkamp
reviewed
Dec 17, 2019
swaterkamp
approved these changes
Dec 17, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove severity levels from filter if all levels are unchecked.
Checklist: