Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

handle undefined trash in case of an error #1908

Merged
merged 3 commits into from
Jan 9, 2020

Conversation

sarahd93
Copy link
Contributor

@sarahd93 sarahd93 commented Jan 9, 2020

In case of an error on the trashcanpage the trash might be undefined which would cause the trashcanpage to break. This PR should fix that by catching this special case.

Checklist:

@sarahd93 sarahd93 force-pushed the trashcanpage_master branch from 094fb8c to 017593c Compare January 9, 2020 10:50
@codecov
Copy link

codecov bot commented Jan 9, 2020

Codecov Report

Merging #1908 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1908      +/-   ##
==========================================
- Coverage   49.22%   49.22%   -0.01%     
==========================================
  Files        1043     1043              
  Lines       24671    24674       +3     
  Branches     6999     6974      -25     
==========================================
  Hits        12145    12145              
- Misses      11377    11379       +2     
- Partials     1149     1150       +1
Impacted Files Coverage Δ
gsa/src/web/pages/extras/trashcanpage.js 3.27% <0%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdb5c6f...eb30ab9. Read the comment docs.

@sarahd93 sarahd93 marked this pull request as ready for review January 9, 2020 10:58
@sarahd93 sarahd93 requested a review from a team January 9, 2020 10:58
@sarahd93 sarahd93 requested a review from swaterkamp January 9, 2020 11:07
@sarahd93 sarahd93 requested a review from bjoernricks January 9, 2020 11:12
@bjoernricks bjoernricks merged commit 2822be4 into greenbone:master Jan 9, 2020
@sarahd93 sarahd93 deleted the trashcanpage_master branch January 9, 2020 13:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants