Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix bulk tagging by selection #1985

Merged
merged 2 commits into from
Feb 24, 2020

Conversation

swaterkamp
Copy link
Member

Instead of sending the resource_ids for the save_tag command as a set, send it as array. Sets don't work as command parameter.

Checklist:

@swaterkamp swaterkamp requested review from sarahd93 and a team February 24, 2020 10:30
@swaterkamp swaterkamp self-assigned this Feb 24, 2020
@swaterkamp swaterkamp changed the base branch from master to gsa-9.0 February 24, 2020 10:34
@swaterkamp swaterkamp force-pushed the BulkTaggingBySelection branch from 7e8f8d8 to 4a0d2c8 Compare February 24, 2020 10:34
@codecov
Copy link

codecov bot commented Feb 24, 2020

Codecov Report

Merging #1985 into gsa-9.0 will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           gsa-9.0    #1985      +/-   ##
===========================================
- Coverage    49.97%   49.97%   -0.01%     
===========================================
  Files         1067     1067              
  Lines        24968    24969       +1     
  Branches      7061     7035      -26     
===========================================
  Hits         12479    12479              
- Misses       11357    11358       +1     
  Partials      1132     1132
Impacted Files Coverage Δ
gsa/src/web/entities/container.js 45.79% <0%> (-0.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8547e87...299ddcb. Read the comment docs.

@swaterkamp swaterkamp force-pushed the BulkTaggingBySelection branch from 4a0d2c8 to 299ddcb Compare February 24, 2020 10:48
@swaterkamp swaterkamp merged commit 467f33e into greenbone:gsa-9.0 Feb 24, 2020
@swaterkamp swaterkamp deleted the BulkTaggingBySelection branch April 20, 2021 08:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants