Improve error handling for invalid detailspage links #1986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfi-gb
suggested changes
Feb 24, 2020
bjoernricks
requested changes
Feb 24, 2020
Co-Authored-By: cfi-gb <34644702+cfi-gb@users.noreply.github.com>
Co-Authored-By: cfi-gb <34644702+cfi-gb@users.noreply.github.com>
Co-Authored-By: cfi-gb <34644702+cfi-gb@users.noreply.github.com>
Co-Authored-By: Björn Ricks <bjoern.ricks@gmail.com>
sarahd93
force-pushed
the
invalid_secinfo_links_gsa9
branch
from
c2895d0 to
8a467fb
Compare
Codecov Report
@@ Coverage Diff @@
## gsa-9.0 #1986 +/- ##
===========================================
- Coverage 49.97% 49.96% -0.01%
===========================================
Files 1067 1067
Lines 24969 24976 +7
Branches 7035 7064 +29
===========================================
+ Hits 12479 12480 +1
- Misses 11358 11360 +2
- Partials 1132 1136 +4
Continue to review full report at Codecov.
|
swaterkamp
approved these changes
Feb 24, 2020
bjoernricks
approved these changes
Feb 24, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve error messages for invalid detailspage links. Show extra information for invalid CVE links.
Checklist: