Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix audit listpage observer tooltip #2048

Merged
merged 6 commits into from
Mar 18, 2020

Conversation

sarahd93
Copy link
Contributor

ProvideViewIcon in audit row was only shown for users but not for roles and groups. Applied the changes in task model to audits as well to fix this.

Checklist:

@sarahd93 sarahd93 marked this pull request as ready for review March 18, 2020 13:40
@sarahd93 sarahd93 requested a review from a team March 18, 2020 13:40
@sarahd93 sarahd93 changed the base branch from master to gsa-9.0 March 18, 2020 13:44
@codecov
Copy link

codecov bot commented Mar 18, 2020

Codecov Report

Merging #2048 into gsa-9.0 will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           gsa-9.0    #2048      +/-   ##
===========================================
+ Coverage     50.2%   50.24%   +0.03%     
===========================================
  Files         1070     1070              
  Lines        25129    25141      +12     
  Branches      7102     7133      +31     
===========================================
+ Hits         12617    12633      +16     
+ Misses       11368    11366       -2     
+ Partials      1144     1142       -2
Impacted Files Coverage Δ
gsa/src/gmp/models/task.js 97.61% <100%> (-0.06%) ⬇️
gsa/src/web/pages/audits/row.js 91.66% <100%> (+12.25%) ⬆️
gsa/src/gmp/parser.js 99.16% <100%> (+0.01%) ⬆️
gsa/src/gmp/models/audit.js 97.14% <100%> (+0.3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cacf022...7a95b89. Read the comment docs.

@swaterkamp swaterkamp self-requested a review March 18, 2020 15:18
Copy link
Member

@swaterkamp swaterkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@sarahd93 sarahd93 merged commit c6b0b9e into greenbone:gsa-9.0 Mar 18, 2020
@sarahd93 sarahd93 deleted the audit_observers_gsa9 branch March 18, 2020 15:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants