Fix missing loading indicator for test alert icon #2156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2156 +/- ##
=======================================
Coverage 52.70% 52.70%
=======================================
Files 1069 1069
Lines 25666 25666
Branches 7269 7296 +27
=======================================
Hits 13528 13528
Misses 11024 11024
Partials 1114 1114
Continue to review full report at Codecov.
|
bjoernricks
approved these changes
May 11, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test alert button is missing a loading indicator. Return a promise for handleTestAlert to make the loading indicator show up.
Checklist: