Clear cache and store #797

bjoernricks · 2018-07-13T11:29:18Z

No description provided.

The caches aren't used inside of the Gmp class. Therefore they shouldn't be stored within Gmp.

Also add debug output when clearing caches.

Call listeners on gmp.logout.

The catch clause can never occur.

Change the current state to be empty if the clear store action is dispatched. This will pass the empty state to all reducers and therefore re-initalize the complete state to the defaults from the reducers.

Add gmp logout listener in app to clear all caches and also the redux store on logout.

codecov · 2018-07-13T11:32:13Z

Codecov Report

Merging #797 into master will decrease coverage by <.01%.
The diff coverage is 3.12%.

@@            Coverage Diff            @@
##           master    #797      +/-   ##
=========================================
- Coverage    6.78%   6.78%   -0.01%     
=========================================
  Files         780     781       +1     
  Lines       25967   25987      +20     
  Branches     5832    5818      -14     
=========================================
+ Hits         1762    1763       +1     
- Misses      21753   21771      +18     
- Partials     2452    2453       +1

Impacted Files	Coverage Δ
gsa/src/web/components/bar/titlebar.js	`0% <ø> (ø)`	⬆️
gsa/src/web/store/reducers.js	`0% <0%> (ø)`	⬆️
gsa/src/gmp/gmp.js	`1.16% <0%> (-0.09%)`	⬇️
gsa/src/web/app.js	`0% <0%> (ø)`	⬆️
gsa/src/web/store/actions.js	`0% <0%> (ø)`
gsa/src/gmp/cache.js	`2.63% <33.33%> (+2.63%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05e79eb...ed55c96. Read the comment docs.

bjoernricks requested a review from swaterkamp as a code owner July 13, 2018 11:29

bjoernricks added 10 commits July 13, 2018 13:32

Don't export Gmp class by name

1014f8b

Don't pass caches to gmp instance

ce7a20d

The caches aren't used inside of the Gmp class. Therefore they shouldn't be stored within Gmp.

Use for of loop in CacheFactory clearAll method

14fa3a9

Also add debug output when clearing caches.

Fix logic on gmp.logout

ecbf6f9

Add debug output after successful logout

7687e6f

Allow to notify about logouts

db9f1d0

Call listeners on gmp.logout.

Remove catch clause when calling gmp.logout promise

87b3fb4

The catch clause can never occur.

Add action to clear the redux store

b91b050

Update the root reducer to clear the store

88b4497

Change the current state to be empty if the clear store action is dispatched. This will pass the empty state to all reducers and therefore re-initalize the complete state to the defaults from the reducers.

Clear caches and store on logout

ed55c96

Add gmp logout listener in app to clear all caches and also the redux store on logout.

swaterkamp approved these changes Jul 13, 2018

View reviewed changes

swaterkamp merged commit 0aac016 into greenbone:master Jul 13, 2018

bjoernricks deleted the clear-cache-and-store branch July 13, 2018 11:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clear cache and store #797

Clear cache and store #797

bjoernricks commented Jul 13, 2018

codecov bot commented Jul 13, 2018 •

edited

Loading

Clear cache and store #797

Clear cache and store #797

Conversation

bjoernricks commented Jul 13, 2018

codecov bot commented Jul 13, 2018 • edited Loading

Codecov Report

codecov bot commented Jul 13, 2018 •

edited

Loading