Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Reduce default max height for dialogs #843

Merged
merged 1 commit into from
Jul 31, 2018

Conversation

swaterkamp
Copy link
Member

With the lower height, there should be less issues with the Save-button
being unreachable.

With the lower height, there should be less issues with the Save-button
being unreachable.
@swaterkamp swaterkamp self-assigned this Jul 31, 2018
@swaterkamp swaterkamp requested a review from bjoernricks July 31, 2018 10:41
@codecov
Copy link

codecov bot commented Jul 31, 2018

Codecov Report

Merging #843 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #843   +/-   ##
======================================
  Coverage    7.08%   7.08%           
======================================
  Files         822     822           
  Lines       26058   26058           
  Branches     5923    5906   -17     
======================================
  Hits         1845    1845           
  Misses      21791   21791           
  Partials     2422    2422
Impacted Files Coverage Δ
gsa/src/web/components/dialog/dialog.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17a75bc...9a6384c. Read the comment docs.

@swaterkamp swaterkamp merged commit 0743462 into greenbone:master Jul 31, 2018
@swaterkamp swaterkamp deleted the DialogSize branch November 30, 2018 09:02
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants