Usersettings default severity #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always format passed default severity to a one digit decimal point value when saving the user settings. A JavaScript Number of 10 is the same as 10.0 but the backend checks for fractional digits. Fixes #890
Codecov Report
@@ Coverage Diff @@
## master #907 +/- ##
=========================================
+ Coverage 7.35% 7.36% +0.01%
=========================================
Files 825 826 +1
Lines 26933 26936 +3
Branches 5684 5703 +19
=========================================
+ Hits 1980 1984 +4
- Misses 22542 22544 +2
+ Partials 2411 2408 -3
Continue to review full report at Codecov.
|
swaterkamp
reviewed
Sep 3, 2018
| expect(severityValue(1.0)).toEqual('1.0'); | ||
| expect(severityValue(1.1)).toEqual('1.1'); | ||
| expect(severityValue(1.10)).toEqual('1.1'); | ||
| expect(severityValue(1.15)).toEqual('1.1'); |
There was a problem hiding this comment.
Shouldn't this equal 1.2 as well?
swaterkamp
approved these changes
Sep 3, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Centralize formatting of numbers to fix saving the default severity user setting.