Use correct type size for port elements #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ports which are used for TCP pings are stored in a GArray. TCP ports are of size uint16_t. Now the array elements are all of size uint16_t. When ports are added to the array they are first cast to the appropriate type. The port lists was already validated, so there are no values which are bigger than uint16_t in it.
jjnicola
approved these changes
Aug 27, 2020
This was referenced Aug 27, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Fix type conversion bug. Because of this bug it could happen that not all ports are added correctly to the port list for TCP pings.
If we init an GArray with elements of type int and then get elements from this array with g_array_index (array, uint16_t, index) we get 0 every second port. This is fixed by always using uint16_t when initing the array and when filling it.
Why:
Bugs have to be fixed.
How:
Printed out the array of ports after it got filled. Before fix every second port was 0, after fix all ports are filled as expected.
Checklist: