Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Wrap run-p value in single quotes to support yarn 2+ #77

Closed
scheinercc opened this issue Nov 13, 2023 · 4 comments
Closed

Wrap run-p value in single quotes to support yarn 2+ #77

scheinercc opened this issue Nov 13, 2023 · 4 comments
Assignees

Comments

@scheinercc
Copy link

Hey Greg,
just in case you do want to support yarn at all it seems that for yarn 2+ (v4 just came out hence I remembered to upgrade from v1) run-p values need to be wrapped in single quotes, e.g.

"watch": "run-p watch:**",

becomes

"watch": "run-p 'watch:**'",

with no issue for npm.

Background: mysticatea/npm-run-all#200 (comment)

@gregsullivan
Copy link
Owner

Hey Albert—Thanks for this!

Two quick questions for you:

  • What OS are you using?
  • Could you do me a favour and try this: "watch": "run-p \"watch:**\"",

If both work, I might favour the version with " characters given the suggestion that it's compatible with Windows:

mysticatea/npm-run-all#200 (comment)

Would appreciate your thoughts on this!

@gregsullivan gregsullivan self-assigned this Nov 14, 2023
@scheinercc
Copy link
Author

Hey Greg!

I am on macOS 14 and "watch": "run-p \"watch:**\"", works just as well, so yeah I would say using that makes absolute sense given that comment.

I also tested "development": "run-p \"development:**\"", etc.

@gregsullivan
Copy link
Owner

Awesome, thanks for this! I'm working on a minor update for release (potentially today), and this has already been included.

gregsullivan added a commit that referenced this issue Nov 16, 2023
@gregsullivan
Copy link
Owner

Fixed here:

8e9f431

Please let me know if you encounter any other issues with Yarn, specific to npm-run-all or otherwise!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants