Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix start_cursor request type (issue:#498) #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lizard-boy
Copy link

Issue on makenotion#498

Description

This PR resolves a type mismatch issue encountered when using the start_cursor in database.query.
The current implementation leads to a conflict between string | undefined and string | null in various scenarios involving the cursor.

Changes Made

Updated the type for start_cursor in QueryParameters to accept both null and undefined.

Expected Behavior:

With this change, you will no longer face typing issues when assigning next_cursor from a query response to a variable.

  let databaseId = "<some_id>"
  let entries = []
  let cursor: string | null = null

  while (true) {
    const { results, has_more, next_cursor }: QueryDatabaseResponse =
      await notion.databases.query({
        database_id: databaseId,
        start_cursor: cursor,
      })

    cursor = next_cursor  // Now this works without typing issues
    entries.push(...results)

    if (!has_more) {
      break
    }
  }

  return entries

@lizard-boy
Copy link
Author

@greptileai

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants