Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Ctrl+Z and Ctrl+Shift+Z #29

Closed
1j01 opened this issue Dec 4, 2017 · 3 comments
Closed

Ctrl+Z and Ctrl+Shift+Z #29

1j01 opened this issue Dec 4, 2017 · 3 comments

Comments

@1j01
Copy link

1j01 commented Dec 4, 2017

Ctrl+Z should undo and Ctrl+Shift+Z should redo, on Windows and Linuxes.

If you're worried about conflicting with native browser undo/redo, well, you can defer to the default behavior if any text field is focused and preventDefault() otherwise.

If you're concerned with consistency between shortcuts, with Ctrl+N being unusable in some (maybe all or most) browsers, you could support both Ctrl and Alt+[Shift+]Z.

Also, I would support Ctrl+Y for redo, as many Windows users are used to.

@mr21
Copy link
Member

mr21 commented Dec 4, 2017

You right, I am not used to these new shortcuts anyway. I will let Ctrl triggerable where I can.
Thanks for your advises :)

mr21 added a commit that referenced this issue Dec 12, 2017
@mr21
Copy link
Member

mr21 commented Dec 12, 2017

@1j01 you can see the changes if you click the shortcut popup.
Feel free to continue reporting bugs / code idea etc. it was a productive pleasure :)

@mr21 mr21 closed this as completed Dec 12, 2017
@1j01
Copy link
Author

1j01 commented Dec 14, 2017

The app feels so much more solid with those few changes. :D

Feel free to continue reporting bugs / code idea etc.

I think I will! This looks like a very promising app. I'll definitely follow its development and open issues
probably every time I try it out. Don't feel pressured to address them in any particular timeframe, though.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

2 participants