Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Notes created at wrong location #30

Closed
1j01 opened this issue Dec 5, 2017 · 2 comments
Closed

Notes created at wrong location #30

1j01 opened this issue Dec 5, 2017 · 2 comments
Labels
bug

Comments

@1j01
Copy link

1j01 commented Dec 5, 2017 •
edited
Loading

gridsound bug

It's offset by half a cell when creating notes.
And also when resizing notes, but in that case it's reasonable.

So you could give _getMouseBeat a parameter, or split it into two functions,
one to give you the nearest position (with round), and you to give the cell (with floor),
maybe _getBeatNearestToMouse and _getBeatForCellUnderMouse
@mr21
Copy link
Member

mr21 commented Dec 7, 2017

Thanks, you right, I will investigate this to night

mr21 added a commit to gridsound/gs-ui-components that referenced this issue Dec 9, 2017
@mr21
gsuiTimeLine: .beatRound/Floor(), gridsound/daw/issues/30
2bdaaf7
mr21 added a commit to gridsound/gs-ui-components that referenced this issue Dec 9, 2017
@mr21
gsuiGridSamples: use gsuiTimeLine.beatRound/Floor() instead of _round…
72e18c7 
…(), gridsound/daw/issues/30
@mr21
Copy link
Member

mr21 commented Dec 9, 2017 •
edited
Loading

Thanks again :) it will be online soon

@mr21 mr21 closed this as completed Dec 9, 2017
@mr21 mr21 added the bug label Jul 12, 2018
mr21 added a commit to gridsound/gs-ui-components that referenced this issue Apr 5, 2019
@mr21
gsuiTimeLine: .beatRound/Floor(), gridsound/daw/issues/30
746cbc9
mr21 added a commit to gridsound/gs-ui-components that referenced this issue Apr 5, 2019
@mr21
gsuiGridSamples: use gsuiTimeLine.beatRound/Floor() instead of _round…
dbcc313 
…(), gridsound/daw/issues/30
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mr21 @1j01