Skip to content

Conversation

SlimaneAmar
Copy link
Contributor

No description provided.

LE SAULNIER Kevin and others added 3 commits March 26, 2024 15:10
Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier@rte-france.com>
Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier@rte-france.com>
Signed-off-by: Slimane AMAR <amarsli@gm0winl104.bureau.si.interne>
Copy link
Contributor

@Tristan-WorkGH Tristan-WorkGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 missing config + 1 question + 1 suggestion

Comment on lines +53 to +54
ports:
- "9187:9187"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did we need to access it?

Suggested change
ports:
- "9187:9187"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes for tests
Only for dev

Signed-off-by: Slimane AMAR <amarsli@gm0winl104.bureau.si.interne>
@SlimaneAmar SlimaneAmar changed the title Dashboards postgres & rabbitmq [WIP] Dashboards postgres & rabbitmq Apr 26, 2024
@Tristan-WorkGH Tristan-WorkGH self-requested a review April 26, 2024 08:35
Base automatically changed from change_metric_labels to main April 29, 2024 06:37
Slimane AMAR added 2 commits April 29, 2024 12:07
Signed-off-by: Slimane AMAR <amarsli@gm0winl104.bureau.si.interne>
@SlimaneAmar SlimaneAmar changed the title [WIP] Dashboards postgres & rabbitmq [WIP] Dashboards postgres & rabbitmq & elasticsearch May 16, 2024
Signed-off-by: Slimane AMAR <amarsli@gm0winl104.bureau.si.interne>
@SlimaneAmar SlimaneAmar requested review from Tristan-WorkGH and antoinebhs and removed request for Tristan-WorkGH May 16, 2024 12:49
Copy link
Contributor

@antoinebhs antoinebhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code OK
Test OK

I mention here that the JSON dashboards are from:

They will be later extended with alerts.
postgres_exporter does not support custom queries in recent versions as per this commit prometheus-community/postgres_exporter#801

@SlimaneAmar SlimaneAmar changed the title [WIP] Dashboards postgres & rabbitmq & elasticsearch Dashboards postgres & rabbitmq & elasticsearch Jun 6, 2024
@SlimaneAmar SlimaneAmar merged commit c9c04c7 into main Jun 6, 2024
@SlimaneAmar SlimaneAmar deleted the monitoring_postgres branch June 6, 2024 07:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants