Update feature uniqueness validation to take into account revision context #1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susannasiebert
added
the
bugfix
acoffman
reviewed
Oct 16, 2024
|
|
||
| duplicate_name = if in_revision_validation_context | ||
| base_query | ||
| .where.not(feature_instance_id: revision_target_id) |
There was a problem hiding this comment.
I think the revision target id here will always be the feature id, not the feature instance id, but we can double check.
There was a problem hiding this comment.
I made that change specifically because I was running into this issue where the revision_target_id was the feature_instance_id when I was testing fusion variant coordinate revisions locally. However, maybe that is not intended and the revision should capture the feature id?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.