Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add COSMO implicit solvation model #274

Merged
merged 8 commits into from
Mar 3, 2021
Merged

Conversation

awvwgk
Copy link
Member

@awvwgk awvwgk commented Jun 23, 2020

  • use ddCOSMO library to solve COSMO equations

@ghutchis
Copy link

ghutchis commented Sep 4, 2020

Looks great! Is it possible to get the solvent volume / surface area printed as computed properties (or via the Python API). I'd love to use XTB / CREST to augment solubility predictions.

@awvwgk
Copy link
Member Author

awvwgk commented Sep 4, 2020

See #336 for the extension of the C-API w.r.t. to solvation. I have not yet decided on the necessary API objects and calls to implement this, but it is on the list.

@ghutchis
Copy link

ghutchis commented Sep 6, 2020

I also saw in the documentation about:

$write
   gbsa=true

This looks like it would give what we want - grabbing the SASA (even h-bond terms).

@awvwgk
Copy link
Member Author

awvwgk commented Sep 6, 2020

@ghutchis I always advise against parsing standard output from xtb, save yourself the pain to decrypt the ascii table and just add the terms you are interested in to the JSON dump.
Also, we should probably move this discussion to a new issue than...

@awvwgk awvwgk modified the milestones: v6.4.0, v6.5.0 Dec 30, 2020
@awvwgk awvwgk force-pushed the cosmo branch 2 times, most recently from 7080355 to 06736f2 Compare January 29, 2021 08:23
@codecov
Copy link

codecov bot commented Jan 29, 2021

Codecov Report

Merging #274 (c011eb8) into master (f6b888f) will increase coverage by 0.97%.
The diff coverage is 86.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #274      +/-   ##
==========================================
+ Coverage   40.79%   41.77%   +0.97%     
==========================================
  Files         304      307       +3     
  Lines       50792    51721     +929     
==========================================
+ Hits        20722    21605     +883     
- Misses      30070    30116      +46     
Impacted Files Coverage Δ
src/prog/main.F90 40.35% <0.00%> (-0.73%) ⬇️
src/solv/input.F90 0.00% <ø> (ø)
src/set_module.f90 27.85% <33.33%> (+0.01%) ⬆️
src/solv/model.f90 55.59% <81.81%> (+4.38%) ⬆️
src/solv/ddcosmo/core.f90 84.04% <84.04%> (ø)
src/solv/ddcosmo/solver.f90 84.26% <84.26%> (ø)
src/solv/cosmo.f90 94.31% <94.31%> (ø)
TESTSUITE/gfn1.f90 100.00% <100.00%> (ø)
TESTSUITE/gfn2.f90 77.74% <100.00%> (+2.19%) ⬆️
TESTSUITE/tests_peeq.f90 94.26% <100.00%> (+0.09%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6b888f...5af24cb. Read the comment docs.

@awvwgk awvwgk modified the milestones: v6.5.0, v6.4.1 Mar 3, 2021
@awvwgk awvwgk merged commit 57eb81c into grimme-lab:master Mar 3, 2021
@awvwgk awvwgk deleted the cosmo branch March 3, 2021 14:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants