Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Adjust optimization thresholds for DCOSMO-RS level #383

Merged
merged 1 commit into from
Nov 25, 2020
Merged

Adjust optimization thresholds for DCOSMO-RS level #383

merged 1 commit into from
Nov 25, 2020

Conversation

awvwgk
Copy link
Member

@awvwgk awvwgk commented Nov 23, 2020 •
edited
Loading

  • change gradient convergence from 0.002 to 0.0025 for optimization level lax

@awvwgk
Adjust optimization thresholds for DCOSMO-RS level
758412e 
- change gradient convergence from 0.002 to 0.0025
@awvwgk awvwgk requested a review from fabothch November 23, 2020 21:16
@codecov
Copy link

codecov bot commented Nov 23, 2020

Codecov Report

Merging #383 (758412e) into master (0b1edcd) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #383   +/-   ##
=======================================
  Coverage   40.55%   40.55%           
=======================================
  Files         302      302           
  Lines       50622    50622           
=======================================
  Hits        20529    20529           
  Misses      30093    30093
Impacted Files Coverage Δ
src/optimizer.f90 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b1edcd...758412e. Read the comment docs.

@fabothch
Copy link
Member

looks fine!

fabothch
fabothch approved these changes Nov 25, 2020 •
edited
Loading
View reviewed changes
@fabothch fabothch merged commit f843c16 into grimme-lab:master Nov 25, 2020
@awvwgk awvwgk deleted the opt-thr branch November 25, 2020 12:07
@awvwgk awvwgk added this to the v6.4.0 milestone Jan 23, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@fabothch fabothch fabothch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v6.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@awvwgk @fabothch