Make c-api example MSVC compatible #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSVC cl has stricter rules about constants than other compilers (e.g variables declared `const` are not constant at compile time and so aren't consider constant). This means the compiler won't allow `const` variables to be used to declare array sizes. The changes here explicitly allocate/free memory for arrays so that the MSVC cl compiler can run this example. The c-api itself should work without these changes, but the example was incompatible and was halting compilation. Signed-off-by: Ty <ty.balduf@schrodinger.com>
Signed-off-by: Ty <ty.balduf@schrodinger.com>
awvwgk
approved these changes
Jun 27, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSVC cl has stricter rules about constants than other compilers
(e.g variables declared
constare not constant at compile time and soaren't consider constant). This means the compiler won't allow
constvariables to be used to declare array sizes.
The changes here explicitly allocate/free memory for arrays so that
the MSVC cl compiler can run this example. The c-api itself should work
without these changes, but the example was incompatible and was halting
compilation.