-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Impossible to use gogo/protobuf registered types in gRPC Status errors #576
Comments
johanbrandhorst
added a commit
to johanbrandhorst/grpc-gateway
that referenced
this issue
Mar 17, 2018
johanbrandhorst
added a commit
to johanbrandhorst/grpc-gateway
that referenced
this issue
Mar 17, 2018
johanbrandhorst
added a commit
to johanbrandhorst/grpc-gateway
that referenced
this issue
Apr 24, 2018
If this is the only issue from using gogo types we should absolutely get this fixed. |
Yeah I think this will go some way but it's not the only problem. Please see the grpc-gateway section of my post on gogoproto compatibility: https://jbrandhorst.com/post/gogoproto/. Theres nothing that cant be worked around though. |
johanbrandhorst
added a commit
to johanbrandhorst/grpc-gateway
that referenced
this issue
Jun 19, 2018
johanbrandhorst
added a commit
to johanbrandhorst/grpc-gateway
that referenced
this issue
Jun 19, 2018
Fixes grpc-ecosystem#576. Adds a test case for marshalling of details as well.
johanbrandhorst
added a commit
to johanbrandhorst/grpc-gateway
that referenced
this issue
Jun 22, 2018
Fixes grpc-ecosystem#576. Adds a test case for marshalling of details as well.
achew22
pushed a commit
that referenced
this issue
Jun 22, 2018
Fixes #576. Adds a test case for marshalling of details as well.
adasari
pushed a commit
to adasari/grpc-gateway
that referenced
this issue
Apr 9, 2020
Fixes grpc-ecosystem#576. Adds a test case for marshalling of details as well.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
The gRPC-Gateway uses the gRPC
status
package for writing rich gRPC errors to the JSON response of a gRPC call. Unfortunately, the use ofstatus.Details()
directly assumes all proto message types stored in the status are registered with thegolang/protobuf
proto type registry. Ideally the gRPC Gateway would simply allow the JSON marshaller to marshal the messages, which would leave such type resolution to the marshaller, and not the runtime.To be specific, this bug refers to the handling of the status in
grpc-gateway/runtime/errors.go
Lines 100 to 109 in 58f78b9
The text was updated successfully, but these errors were encountered: