Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add HTTP error code, error status to responseStreamChunk Error #58

Closed
mwitkow opened this issue Sep 23, 2015 · 1 comment
Closed

Add HTTP error code, error status to responseStreamChunk Error #58

mwitkow opened this issue Sep 23, 2015 · 1 comment

Comments

@mwitkow
Copy link
Member

mwitkow commented Sep 23, 2015

When using unitary-to-streaming requests, it is hard to reason about HTTP error codes based on a chunk that contains error: it only contains the text of the error response.

Instead, it would be useful for the error field of a chunk to be structured:

  • grpc_code containing the code of the RPC error (to avoid the pain of extracting it from the error string)
  • http_code that is from HTTPStatusFromCode
  • message containing the current string of the error
  • http_status containing a textual representation of the grpc_code or http_code.
@mwitkow
Copy link
Member Author

mwitkow commented Oct 1, 2015

Yay, thanks @kdima!

@mwitkow mwitkow closed this as completed Oct 1, 2015
ithinker1991 pushed a commit to tronprotocol/grpc-gateway that referenced this issue Jun 18, 2018
…or_walletExtension_service

add wallet extension service
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant