Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix ruby gen command #275

Merged
merged 2 commits into from
Mar 4, 2017
Merged

Fix ruby gen command #275

merged 2 commits into from
Mar 4, 2017

Conversation

bluehallu
Copy link
Contributor

protoc-gen-grpc-ruby doesn't work in my machine and google points to this readme as the only occurance...

protoc-gen-grpc-ruby doesn't work in my machine and google points to this readme as the only occurance...
Importing annotations.proto will produce a dependency in the generated stubs. This requires the relevant import when using the stubs even if the annotations are not actually used at all by anything but the grpc-gateway plugin.
@tmc
Copy link
Collaborator

tmc commented Feb 17, 2017

@bluehallu thank you for your contribution -- have you signed the cla?

@bluehallu
Copy link
Contributor Author

@tmc Just did :)

@tmc tmc merged commit fdcb7ea into grpc-ecosystem:master Mar 4, 2017
@tamalsaha tamalsaha mentioned this pull request Mar 30, 2017
1 task
adasari pushed a commit to adasari/grpc-gateway that referenced this pull request Apr 9, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants