Better compatibility to field names generated by protoc-gen-go #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice change! |
|
Will this have any affect on the field names in the swagger documentation? |
Use the metadata proto.GetProperty returns instead. Since the conversion rule is getting complicated, it is hard to emulate the rule. c.f. #85
Use the implementation in protoc-gen-go itself
yugui
force-pushed
the
feature/avoid-custom-pascal-snake
branch
from
ed4040d to
1da1435
Compare
I don't think so because swagger generator does not directly use name conversion, and the currently |
|
LGTM |
yugui
added a commit
that referenced
this pull request
Feb 4, 2016
Better compatibility to field names generated by protoc-gen-go
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop emulating the conversion rule. Use their implementation of the name conversion instead.
c.f. #85