Skip to content

export additional generated protobuf symbols #792

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

devoncarew
Copy link
Contributor

  • export additional generated protobuf symbols (Any)

From the health check, we're referencing symbols from the public api that are not exported. This exports some of those symbols.

The following packages contain symbols visible in the public API, but not exported by the library.
Export these symbols or remove them from your publicly visible API.

Package	Leaked API symbols
grpc	$1.Duration
    	Any

Copy link

github-actions bot commented Jun 9, 2025

PR Health

Breaking changes ⚠️
Package Change Current Version New Version Needed Version Looking good?
grpc Breaking 4.1.0 4.2.0-wip 5.0.0
Got "4.2.0-wip" expected >= "5.0.0" (breaking changes)
⚠️

This check can be disabled by tagging the PR with skip-breaking-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

API leaks ⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
grpc $1.Duration

This check can be disabled by tagging the PR with skip-leaking-check.

@devoncarew
Copy link
Contributor Author

It looks like Duration is leaked from package:grpc/src/generated/google/rpc/error_details.pb.dart, RetryInfo.retryDelay. This would take more work to address; most people who currently import lib/grpc.dart will have a conflict between the protobuf Duration and the one from dart.core.

@devoncarew devoncarew marked this pull request as ready for review June 20, 2025 15:49
@devoncarew
Copy link
Contributor Author

@mit-mit, @szakarias, @sigurdm - I see you listed in the https://github.com/grpc/grpc-dart/blob/master/MAINTAINERS.md file; if any of you have admin rights to this repo, can you add me as a committer? Thanks!

@devoncarew
Copy link
Contributor Author

cc @mosuem for review

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants