Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

metadata: copy slices in FromContext() functions #5267

Merged
merged 2 commits into from
Mar 22, 2022
Merged

metadata: copy slices in FromContext() functions #5267

merged 2 commits into from
Mar 22, 2022

Conversation

menghanl
Copy link
Contributor

@menghanl menghanl commented Mar 22, 2022 •
edited
Loading

32d5490#commitcomment-69226467

RELEASE NOTES:

  • metadata: make a copy of the value slices in FromContext() functions so that modifications won't be made to the original copy

@menghanl menghanl added this to the 1.46 Release milestone Mar 22, 2022
dfawley
dfawley reviewed Mar 22, 2022
View reviewed changes
metadata/metadata.go Outdated Show resolved Hide resolved
@menghanl menghanl merged commit 2fccb82 into grpc:master Mar 22, 2022
@menghanl menghanl deleted the md_copy branch March 22, 2022 21:15
menghanl referenced this pull request Mar 22, 2022
@menghanl
metadata: convert keys to lowercase in FromContext() (#4416)
32d5490
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@dfawley dfawley dfawley approved these changes

Assignees

@menghanl menghanl

Labels
Type: Bug
Projects
None yet
Milestone
1.46 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@menghanl @dfawley